Review Request 116522: Make KAboutDialog looks better under OSX

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116522/#review51557
-----------------------------------------------------------



File Attachment: after-3.png - after-3.png
<https://git.reviewboard.kde.org//r/116522/#fcomment161>
    There is no way to send an E-Mail anymore?
    
    Mabye use a text link instead for all platforms and get rid of that misused toolbar button altogether.

- Kai Uwe Broulik


On March 1, 2014, 11:06 p.m., Yue Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116522/
> -----------------------------------------------------------
> 
> (Updated March 1, 2014, 11:06 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Removed close button, because About dialog on OSX usually don't have any buttons.
> Don't draw QFrame in title widget because QFrame::styledPanel looks ugly on OSX.
> KToolBar also looks ugly so removed main links and social links.
> Focus shadow for QListView is also ugly so disabled focus.
> 
> Patch should also work for frameworks but it seems files are split to different parts, can anyone tell me where can I find all the files touched in this patch?
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kaboutapplicationdialog.cpp 8c50615 
>   kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp 5b7c278 
>   kdeui/widgets/ktitlewidget.cpp 8464d7e 
> 
> Diff: https://git.reviewboard.kde.org/r/116522/diff/
> 
> 
> Testing
> -------
> 
> Works on OSX 10.9.2
> 
> 
> File Attachments
> ----------------
> 
> before-1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/a7c007c8-08c4-4537-a679-5487ad36d261__before-1.png
> before-2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/66e2b0ca-8a75-4db1-9433-791c44958c3d__before-2.png
> before-3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/9c0b2e5f-9fab-4f15-a916-715a60eb60f2__before-3.png
> after-1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/39880e76-adeb-4d3d-bee3-a9029b4ed060__after-1.png
> after-2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/f8a4472a-1eb7-4a89-9f13-434676547e63__after-2.png
> after-3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/1b290e0c-97f9-448e-b83e-67144773bdbb__after-3.png
> 
> 
> Thanks,
> 
> Yue Liu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140302/4c5dc00f/attachment.htm>