Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

Commit Hook null at kde.org
Sun Jun 29 17:06:08 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118954/#review61186
-----------------------------------------------------------


This review has been submitted with commit 89d4585c087daf9bdc17c4019af8065d23eb2d85 by Dawit Alemayehu to branch KDE/4.13.

- Commit Hook


On June 28, 2014, 11:32 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118954/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 11:32 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 142597
>     http://bugs.kde.org/show_bug.cgi?id=142597
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The attached patch sets the current directory to the current working directory (read: directory in which the open with dialog was run) whenever the KService path is empty. That way we tell KProcess in the context of the current directory instead of the default one it uses, $HOME.
> 
> 
> Diffs
> -----
> 
>   kinit/klauncher.cpp 6c71e99 
>   kio/kio/krun.cpp 590fcf8 
> 
> Diff: https://git.reviewboard.kde.org/r/118954/diff/
> 
> 
> Testing
> -------
> 
> Tested with the example provided in the bug report. Verified the output of the compile process is in the current working directory instead of $HOME.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140629/ed19e5fb/attachment.htm>


More information about the kde-core-devel mailing list