Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118994/#review61179
-----------------------------------------------------------


Thanks for the patch!

I really like the idea to implement CTRL+SHIFT+T to reopen the previously closed tab, makes Dolphin more browser like :)

But please implement this feature in master, because:
1. Dolphins frameworks branch is currently only for fixing KF5/Qt5 related bugs
2. We changed quite a few recent tabs related lines (new DolphinRecentTabsMenu)

So please implement this behavior in DolphinRecentTabsMenu. Thanks!

- Emmanuel Pescosta


On June 28, 2014, 4:44 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118994/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 4:44 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Bugs: 336818
>     http://bugs.kde.org/show_bug.cgi?id=336818
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with the help of Go->'Recently closed tabs' menu).
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 1192f6e 
>   dolphin/src/dolphinmainwindow.cpp 7c9001b 
>   dolphin/src/dolphinui.rc 52826bb 
> 
> Diff: https://git.reviewboard.kde.org/r/118994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140629/60c1cb12/attachment.htm>