Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118954/#review61122
-----------------------------------------------------------



kio/kio/krun.cpp
<https://git.reviewboard.kde.org/r/118954/#comment42568>

    now this line is going to be called if urls is empty, even with an empty service.path() .....
    
    This should be:
    
    if !service.path.isEmpty
      use that
    else if !urls.isEmpty
      use first url
    


- David Faure


On June 28, 2014, 2:09 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118954/
> -----------------------------------------------------------
> 
> (Updated June 28, 2014, 2:09 a.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 142597
>     http://bugs.kde.org/show_bug.cgi?id=142597
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The attached patch sets the current directory to the current working directory (read: directory in which the open with dialog was run) whenever the KService path is empty. That way we tell KProcess in the context of the current directory instead of the default one it uses, $HOME.
> 
> 
> Diffs
> -----
> 
>   kinit/klauncher.cpp 6c71e99 
>   kio/kio/krun.cpp 590fcf8 
> 
> Diff: https://git.reviewboard.kde.org/r/118954/diff/
> 
> 
> Testing
> -------
> 
> Tested with the example provided in the bug report. Verified the output of the compile process is in the current working directory instead of $HOME.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140628/0c103252/attachment.htm>