Review Request 118954: Set directory to current working directory when executing "Open With..." dialog

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118954/#review61109
-----------------------------------------------------------


OK, but this is a half-fix. KRun can also ask klauncher to run apps (it's in fact the default, when a .desktop file exists for the app), so KLauncher::createArgs needs a similar fix as well.


kio/kio/krun.cpp
<https://git.reviewboard.kde.org/r/118954/#comment42554>

    Make sure _urls isn't empty (see the if at the beginning of the method).


- David Faure


On June 26, 2014, 12:15 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118954/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 12:15 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 142597
>     http://bugs.kde.org/show_bug.cgi?id=142597
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The attached patch sets the current directory to the current working directory (read: directory in which the open with dialog was run) whenever the KService path is empty. That way we tell KProcess in the context of the current directory instead of the default one it uses, $HOME.
> 
> 
> Diffs
> -----
> 
>   kio/kio/krun.cpp 590fcf8 
> 
> Diff: https://git.reviewboard.kde.org/r/118954/diff/
> 
> 
> Testing
> -------
> 
> Tested with the example provided in the bug report. Verified the output of the compile process is in the current working directory instead of $HOME.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140627/32b8ff3c/attachment.htm>