Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118947/
-----------------------------------------------------------

(Updated June 26, 2014, 12:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs.


Bugs: 335556
    http://bugs.kde.org/show_bug.cgi?id=335556


Repository: kdelibs


Description
-------

The commit https://projects.kde.org/projects/kde/kdelibs/repository/revisions/48dd1fc50277b861b49613c5f46b6f8b10cc932d introduced a bug:
It factors out the code to convert a time specification to an actual time value into the function makeTimeFromList().
But in that function makeTime(&t, ms, true) is called, whereas the original code called makeTime(&t, ms, false) for the constructor.

This patch fixes it by passing the "utc" parameter to makeTime() instead of "true".

Please note that this bug is also present in Frameworks5.


Diffs
-----

  kjs/date_object.cpp c8d776c 

Diff: https://git.reviewboard.kde.org/r/118947/diff/


Testing
-------

Loaded the test case from the bug report into Konqueror/KHTML. The correct time is shown now like in other browsers, including Konqueror/WebKit.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140626/bca362e9/attachment.htm>