Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date() constructor

Wolfgang Bauer wbauer at
Thu Jun 26 13:03:00 BST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated June 26, 2014, 12:03 p.m.)


This change has been marked as submitted.

Review request for kdelibs.

Bugs: 335556

Repository: kdelibs


The commit introduced a bug:
It factors out the code to convert a time specification to an actual time value into the function makeTimeFromList().
But in that function makeTime(&t, ms, true) is called, whereas the original code called makeTime(&t, ms, false) for the constructor.

This patch fixes it by passing the "utc" parameter to makeTime() instead of "true".

Please note that this bug is also present in Frameworks5.


  kjs/date_object.cpp c8d776c 



Loaded the test case from the bug report into Konqueror/KHTML. The correct time is shown now like in other browsers, including Konqueror/WebKit.


Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list