Review Request 118898: KGamma: Apply user setting at login/startup
Martin Gräßlin
mgraesslin at kde.org
Mon Jun 23 18:18:49 BST 2014
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote:
> > kcmkgamma/init_kgamma.cpp, line 39
> > <https://git.reviewboard.kde.org/r/118898/diff/1/?file=283881#file283881line39>
> >
> > why delete config? I would just use a KSharedConfig::openConfig
>
> Wolfgang Bauer wrote:
> I just copy/pasted the original code.
> That is reverted as well now.
>
> Should I change this anyway?
> But that's not really related to this bugfix, I'd say...
> But that's not really related to this bugfix, I'd say...
no, it isn't. It just highlights how bad reviewboard is for copied content
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118898/#review60809
-----------------------------------------------------------
On June 23, 2014, 7:01 p.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118898/
> -----------------------------------------------------------
>
> (Updated June 23, 2014, 7:01 p.m.)
>
>
> Review request for kde-workspace, Plasma and Marcel Wiesweg.
>
>
> Bugs: 218668
> http://bugs.kde.org/show_bug.cgi?id=218668
>
>
> Repository: kgamma
>
>
> Description
> -------
>
> KGamma's saved user settings are not applied on startup/login. The user has to enter the KCM to apply them.
> This makes it rather useless, as not even saving the settings system-wide really works any more. (this requires an xorg.conf which normally doesn't exist nowadays)
>
> This patch uses kcminit to apply these settings again on login. Apparently this has been forgotten when moving/porting kgamma to KDE4.
>
> PS: As there seems to be no kgamma group and this is desktop-related, I decided to add the kde-workspace and plasma groups for review. I hope that's ok... ;)
>
>
> Diffs
> -----
>
> kcmkgamma/kgamma.cpp 890ba99
> kcmkgamma/kgamma.desktop 3d87513
>
> Diff: https://git.reviewboard.kde.org/r/118898/diff/
>
>
> Testing
> -------
>
> Set a gamma value in the KGamma KCM, logout/login (or reboot), Gamma value
> gets set correctly.
>
> If there's no kgammarc file (or it contains no actual gamma settings), the Gamma value is not changed. It stays at what is configured for X (or its default).
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140623/65ddb4d1/attachment.htm>
More information about the kde-core-devel
mailing list