Review Request 118898: KGamma: Apply user setting at login/startup

Wolfgang Bauer wbauer at tmo.at
Mon Jun 23 18:02:31 BST 2014



> On June 23, 2014, 3:21 p.m., Sebastian K├╝gler wrote:
> > I think there's a couple of problems with this approach:
> > 
> > - This slows down startup for everybody, not just those who changed the setting. I'm not super-familiar with this, but isn't kcminit for this use-case?
> > - Changing startup procedure this late in the game (Plasma 4.x has been on LTS for almost a year, feature frozen for much longer)
> > - This particular KCM is dead in Plasma 5 (not really a reason to not "fix it" in 4.x, but the feature will be lost again
> > 
> > Again, not super-privvy of the whole picture, but isn't color correction the correct solution here?
> 
> Wolfgang Bauer wrote:
>     applykgammasettings is only called on login for people actually installing kgamma (it's a separate tarball and separate package on openSUSE at least).
>     There is no change to plasma's own startup procedure, and no change at all when kgamma is not installed.
>     
>     kcminit is actually used by kgamma right now (it calls the same function), but that only applies when the user enters the KCM. But the point of this setting is to be applied automatically on login/startup.
> 
> Wolfgang Bauer wrote:
>     PS: Sorry, kcminit does seem to be able to apply settings on login. I seem to have confused it with something else...
>     I will have a look at this then.

Thanks for the hint!
Kcminit works just fine. I just had to add some stuff to the .desktop file and rename/export the init function, so the patch is much simpler now.
Apparently it worked the way it is in KDE3 and has been forgotten to be changed when porting/moving kgamma to KDE4?


- Wolfgang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118898/#review60795
-----------------------------------------------------------


On June 23, 2014, 7:01 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118898/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 7:01 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Marcel Wiesweg.
> 
> 
> Bugs: 218668
>     http://bugs.kde.org/show_bug.cgi?id=218668
> 
> 
> Repository: kgamma
> 
> 
> Description
> -------
> 
> KGamma's saved user settings are not applied on startup/login. The user has to enter the KCM to apply them.
> This makes it rather useless, as not even saving the settings system-wide really works any more. (this requires an xorg.conf which normally doesn't exist nowadays)
> 
> This patch uses kcminit to apply these settings again on login. Apparently this has been forgotten when moving/porting kgamma to KDE4.
> 
> PS: As there seems to be no kgamma group and this is desktop-related, I decided to add the kde-workspace and plasma groups for review. I hope that's ok... ;)
> 
> 
> Diffs
> -----
> 
>   kcmkgamma/kgamma.cpp 890ba99 
>   kcmkgamma/kgamma.desktop 3d87513 
> 
> Diff: https://git.reviewboard.kde.org/r/118898/diff/
> 
> 
> Testing
> -------
> 
> Set a gamma value in the KGamma KCM, logout/login (or reboot), Gamma value 
> gets set correctly.
> 
> If there's no kgammarc file (or it contains no actual gamma settings), the Gamma value is not changed. It stays at what is configured for X (or its default). 
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140623/5ad1a81b/attachment.htm>


More information about the kde-core-devel mailing list