Review Request 118898: KGamma: Apply user setting at login/startup

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118898/
-----------------------------------------------------------

(Updated June 23, 2014, 7:01 p.m.)


Review request for kde-workspace, Plasma and Marcel Wiesweg.


Changes
-------

Use kcminit instead of creating a separate executable and starting it via an autostart .desktop file


Bugs: 218668
    http://bugs.kde.org/show_bug.cgi?id=218668


Repository: kgamma


Description (updated)
-------

KGamma's saved user settings are not applied on startup/login. The user has to enter the KCM to apply them.
This makes it rather useless, as not even saving the settings system-wide really works any more. (this requires an xorg.conf which normally doesn't exist nowadays)

This patch uses kcminit to apply these settings again on login. Apparently this has been forgotten when moving/porting kgamma to KDE4.

PS: As there seems to be no kgamma group and this is desktop-related, I decided to add the kde-workspace and plasma groups for review. I hope that's ok... ;)


Diffs (updated)
-----

  kcmkgamma/kgamma.cpp 890ba99 
  kcmkgamma/kgamma.desktop 3d87513 

Diff: https://git.reviewboard.kde.org/r/118898/diff/


Testing
-------

Set a gamma value in the KGamma KCM, logout/login (or reboot), Gamma value 
gets set correctly.

If there's no kgammarc file (or it contains no actual gamma settings), the Gamma value is not changed. It stays at what is configured for X (or its default). 


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140623/fe65283c/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel