Review Request 118366: Porting keyboard module to Framework5

[shivam makkar]

> On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote:
> > kcms/keyboard/flags.cpp, line 21
> > <https://git.reviewboard.kde.org/r/118366/diff/4/?file=276646#file276646line21>
> >
> >     remove?

see the latest revision, apparently the diff is showing all the revisions made to the same file.


> On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote:
> > kcms/keyboard/flags.cpp, line 22
> > <https://git.reviewboard.kde.org/r/118366/diff/4/?file=276649#file276649line22>
> >
> >     wtf happened here? xD

hehe, merge conflict while pull and push :P 


> On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote:
> > kcms/keyboard/kcmmisc.cpp, line 134
> > <https://git.reviewboard.kde.org/r/118366/diff/4/?file=276656#file276656line134>
> >
> >     please, don't add commented code.

latest revision


> On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote:
> > kcms/keyboard/kcmmisc.cpp, line 68
> > <https://git.reviewboard.kde.org/r/118366/diff/4/?file=276658#file276658line68>
> >
> >     I wouldn't do coding style changes while coding.

will add another review dedicated to coding style changes only.


- shivam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118366/#review60569
-----------------------------------------------------------


On June 20, 2014, 9:24 p.m., shivam makkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118366/
> -----------------------------------------------------------
> 
> (Updated June 20, 2014, 9:24 p.m.)
> 
> 
> Review request for kde-workspace, KDE Frameworks and Andriy Rysin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Removed deprecated statements and ported keyboard module to framework 5.
> 
> 
> Diffs
> -----
> 
>   kcms/keyboard/bindings.h c576455 
>   kcms/keyboard/bindings.cpp 21541e0 
>   kcms/keyboard/bindings.cpp 21541e0 
>   kcms/keyboard/bindings.cpp 325dd3c 
>   kcms/keyboard/flags.cpp b768586 
>   kcms/keyboard/flags.cpp b768586 
>   kcms/keyboard/flags.cpp 6d25443 
>   kcms/keyboard/flags.cpp 3fb98e5 
>   kcms/keyboard/iso_codes.h 6a33739 
>   kcms/keyboard/iso_codes.cpp 3e3b210 
>   kcms/keyboard/kcm_keyboard.cpp 42b7fe4 
>   kcms/keyboard/kcm_keyboard.ui 0062d1c 
>   kcms/keyboard/kcm_keyboard.ui 0062d1c 
>   kcms/keyboard/kcm_keyboard_widget.h 657ddda 
>   kcms/keyboard/kcm_keyboard_widget.cpp 21685eb 
>   kcms/keyboard/kcm_keyboard_widget.cpp 21685eb 
>   kcms/keyboard/kcm_keyboard_widget.cpp 2840e26 
>   kcms/keyboard/kcm_keyboard_widget.cpp 9b0f584 
>   kcms/keyboard/kcmmisc.h 411bdd2 
>   kcms/keyboard/kcmmisc.h 411bdd2 
>   kcms/keyboard/kcmmisc.h 1183fb1 
>   kcms/keyboard/kcmmisc.cpp 6f787ea 
>   kcms/keyboard/kcmmisc.cpp 6f787ea 
>   kcms/keyboard/kcmmisc.cpp d14ac2e 
>   kcms/keyboard/kcmmisc.cpp 3327ce5 
>   kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
>   kcms/keyboard/kcmmiscwidget.ui 37fbaf4 
>   kcms/keyboard/keyboard_config.h b86418d 
>   kcms/keyboard/keyboard_config.cpp f3ff97c 
>   kcms/keyboard/keyboard_config.cpp f3ff97c 
>   kcms/keyboard/keyboard_config.cpp 49f059c 
>   kcms/keyboard/keyboard_config.cpp a227a34 
>   kcms/keyboard/keyboard_daemon.h 4edb968 
>   kcms/keyboard/keyboard_daemon.cpp 25673b0 
>   kcms/keyboard/keyboard_daemon.cpp 25673b0 
>   kcms/keyboard/keyboard_daemon.cpp dcda1ec 
>   kcms/keyboard/keyboard_hardware.cpp dca49b6 
>   kcms/keyboard/keyboard_hardware.cpp dca49b6 
>   kcms/keyboard/keyboard_hardware.cpp 9a61159 
>   kcms/keyboard/layout_memory.h df8568c 
>   kcms/keyboard/layout_memory.cpp 9e72361 
>   kcms/keyboard/layout_memory.cpp 9e72361 
>   kcms/keyboard/layout_memory.cpp d78e677 
>   kcms/keyboard/layout_memory_persister.h 8c4b3c5 
>   kcms/keyboard/layout_memory_persister.cpp 8a6118a 
>   kcms/keyboard/layout_memory_persister.cpp 8a6118a 
>   kcms/keyboard/layout_memory_persister.cpp 1dba024 
>   kcms/keyboard/layout_widget.cpp e67b2d7 
>   kcms/keyboard/layouts_menu.h db2f3ff 
>   kcms/keyboard/layouts_menu.cpp fd436c4 
>   kcms/keyboard/layouts_menu.cpp fd436c4 
>   kcms/keyboard/layouts_menu.cpp e357c6a 
>   kcms/keyboard/layouts_menu.cpp 7d4c4d6 
>   kcms/keyboard/x11_helper.h 719b13f 
>   kcms/keyboard/x11_helper.h 385ae28 
>   kcms/keyboard/x11_helper.cpp 0e2806e 
>   kcms/keyboard/x11_helper.cpp cbb2cfc 
>   kcms/keyboard/xinput_helper.h 343d7ed 
>   kcms/keyboard/xinput_helper.h 343d7ed 
>   kcms/keyboard/xinput_helper.cpp b311579 
>   kcms/keyboard/xinput_helper.cpp b311579 
>   kcms/keyboard/xinput_helper.cpp b245e91 
>   kcms/keyboard/xinput_helper.cpp 980338e 
>   kcms/keyboard/xinput_helper.cpp 1c9604b 
>   kcms/keyboard/xinput_helper.cpp 2b374ae 
>   kcms/keyboard/xkb_helper.cpp 967399e 
>   kcms/keyboard/xkb_rules.h 2be8562 
>   kcms/keyboard/xkb_rules.cpp f09e675 
> 
> Diff: https://git.reviewboard.kde.org/r/118366/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> shivam makkar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140620/0f3c4c14/attachment.htm>