Review Request 118851: Kde-baseapps- KF5 replace generic soversion.

Scarlett Clark scarlett at scarlettgatelyclark.com
Fri Jun 20 19:44:04 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118851/
-----------------------------------------------------------

(Updated June 20, 2014, 11:44 a.m.)


Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.


Changes
-------

Implemented suggested changes, still builds with expected results.


Repository: kde-baseapps


Description
-------

I was ending up with so.SOVERSION when building this, so through some research I have come up with this patch to correct the issue.
If there is a better way, please let me know.


Diffs (updated)
-----

  CMakeLists.txt a5588ea 
  dolphin/src/CMakeLists.txt ce629fb 
  lib/konq/CMakeLists.txt 6857e19 

Diff: https://git.reviewboard.kde.org/r/118851/diff/


Testing
-------

Builds fine on Kubuntu Utopic frameworks chroot. Results in the expected:
libdolphinprivate.so
libdolphinprivate.so.4.97.0
libdolphinprivate.so.5
libkdeinit5_dolphin.so
libkonq.so
libkonq.so.4.97.0
libkonq.so.5


Thanks,

Scarlett Clark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140620/e72671cf/attachment.htm>


More information about the kde-core-devel mailing list