Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118749/#review60147
-----------------------------------------------------------

Ship it!


Looks good, except for one error....


konqueror/src/konqmainwindow.cpp
<https://git.reviewboard.kde.org/r/118749/#comment41903>

    no, this should be mainWindow->comboEdit()


- David Faure


On June 14, 2014, 11:01 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118749/
> -----------------------------------------------------------
> 
> (Updated June 14, 2014, 11:01 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Bugs: 320500
>     http://bugs.kde.org/show_bug.cgi?id=320500
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> The attached patch is intended to prevent all crashes that are caused by invalid access of the QLineEdit in Konqueror's URL combobox.
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqmainwindow.h 4ad4c4f 
>   konqueror/src/konqmainwindow.cpp da8c82e 
> 
> Diff: https://git.reviewboard.kde.org/r/118749/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140615/9635de74/attachment.htm>