Review Request 118750: Prevent use after free
Fabian Kosmale
0inkane at googlemail.com
Sun Jun 15 09:18:06 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118750/
-----------------------------------------------------------
(Updated June 15, 2014, 8:18 a.m.)
Review request for kde-workspace and Andriy Rysin.
Changes
-------
Use Thomas' suggestion – nicer way to fix the issue.
Repository: kde-workspace
Description
-------
Prior to this patch, the memory str was pointing to was freed once the ; was reached. By storing the result of opton.toAscii(), the memory is "kept alive".
Diffs (updated)
-----
plasma-desktop/kcms/keyboard/preview/keysymhelper.cpp 67beb80
Diff: https://git.reviewboard.kde.org/r/118750/diff/
Testing
-------
Only recompiled the application so far.
Thanks,
Fabian Kosmale
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140615/dd88475f/attachment.htm>
More information about the kde-core-devel
mailing list