Review Request 118604: Fix wrong escaping in kfilewidget when selecting multiple files

Victor Dodon dodonvictor at gmail.com
Sat Jun 7 17:43:29 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118604/
-----------------------------------------------------------

Review request for kdelibs, Albert Vaca Cintora and Aaron J. Seigo.


Bugs: 335922
    http://bugs.kde.org/show_bug.cgi?id=335922


Repository: kdelibs


Description
-------

Only when selecting multiple files in KFileDialog, if a file contains in the name the characters '#' or '%', it is (wrongly) escaped.

The only modification needed is in kfilewidget.cpp, in slotOk, instead of appending to the stringList the pretty url, append the url.toLocalFile, to prevent the double escaping.


Diffs
-----

  kfile/kfilewidget.cpp fc9b169 

Diff: https://git.reviewboard.kde.org/r/118604/diff/


Testing
-------


Thanks,

Victor Dodon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140607/d9496d7e/attachment.htm>


More information about the kde-core-devel mailing list