Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler

Commit Hook null at kde.org
Thu Jun 5 17:28:04 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118563/#review59348
-----------------------------------------------------------


This review has been submitted with commit 705ec385df2b6fc0c81b046f4323fbd61baadd26 by Wolfgang Bauer to branch master.

- Commit Hook


On June 5, 2014, 4:20 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118563/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 4:20 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> As discussed in https://git.reviewboard.kde.org/r/117091/. Not using the SA_RESTART flag might (in theory) cause the greeter to be aborted (because certain syscalls may be interrupted and fail with EINTR).
> SA_RESTART seems to be the BSD default and is used by "legacy" signal() by default in glibc 2 and later as well, anyway.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/main.cpp 4cac94c 
> 
> Diff: https://git.reviewboard.kde.org/r/118563/diff/
> 
> 
> Testing
> -------
> 
> I'm using this myself for one month without any problems.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140605/0ee095d9/attachment.htm>


More information about the kde-core-devel mailing list