Review Request 118504: Fix libssh timeout type

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118504/#review59225
-----------------------------------------------------------


It seems to make sense +1.

Isn't there a way to make sure this won't happen again or that it isn't happening in other places?

- Aleix Pol Gonzalez


On June 3, 2014, 4:51 p.m., Lutz Heermann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118504/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 4:51 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> While preparing the connection to a SFTP server kio_sftp puts the timeouts to
> libssh's ssh_options_set as pointers to int while libssh expects the them to
> be given as pointers to long. See:
> 
> http://git.libssh.org/projects/libssh.git/tree/src/options.c#n587
> http://git.libssh.org/projects/libssh.git/tree/src/options.c#n601
> 
> I could fix several unpredictable connection problems by kio_sftp with this
> patch.
> 
> 
> Diffs
> -----
> 
>   kioslave/sftp/kio_sftp.cpp 21cffac0e5892944ca6c5b74537ebc4b7fb4738e 
> 
> Diff: https://git.reviewboard.kde.org/r/118504/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lutz Heermann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140604/878e00ce/attachment.htm>