Review Request 119512: Fix saving/loading of file dialog sizes

[Lukáš Tinkl]

> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote:
> > src/platformtheme/kdeplatformfiledialoghelper.h, line 53
> > <https://git.reviewboard.kde.org/r/119512/diff/1/?file=293814#file293814line53>
> >
> >     this will also hit when the window is shaded, minimized or moved to another virtual desktop (unless the compositor keeps it open for other reasons)

The KDirSelectDialog does the same, hence why I reused it.


On Čec. 28, 2014, 12:17 odp., Lukáš Tinkl wrote:
> > If the only issue is the open ::exec() TODO, you might "trick" it by calling ::winId(), then restore the size and ultimately ::exec()
> > 
> > Otherwise you could open an own nested eventloop instead of relying on the dialogs exec, but that'd be less elegant.
> > 
> > In either case I don't see why bringing your own config re/storage.

The trick with winId() unfortunately doesn't work, the dialog gets restored to the default size, not the saved one... :/ Any other ideas?


- Lukáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119512/#review63311
-----------------------------------------------------------


On Čec. 28, 2014, 12:21 odp., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119512/
> -----------------------------------------------------------
> 
> (Updated Čec. 28, 2014, 12:21 odp.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, and Martin Klapetek.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> This patch tries to fix saving/restoring file dialog sizes. Using KWindowConfig::restoreWindowSize() doesn't work here with the modal exec() methods. Instead, the patch uses the same method as KDirSelectDialog. 
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 
>   src/platformtheme/kdirselectdialog.cpp 9a4082a 
>   src/platformtheme/kdirselectdialog_p.h 5a8e758 
> 
> Diff: https://git.reviewboard.kde.org/r/119512/diff/
> 
> 
> Testing
> -------
> 
> Current Plasma 5, working fine :)
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140728/4dc94278/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel