Review Request 119447: meinproc: check both result of parsing and validation
Luigi Toscano
luigi.toscano at tiscali.it
Fri Jul 25 00:42:21 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119447/
-----------------------------------------------------------
(Updated July 24, 2014, 11:42 p.m.)
Status
------
This change has been marked as submitted.
Review request for Documentation, KDE Frameworks and kdelibs.
Repository: kdelibs
Description
-------
For some historical reasons, both results were not checked.
On one side, a parsing error could lead to a failure in one of the subsequent call (doc is NULL), but a validation error could pass unnoticed if not by checking the logs (hint: it happened recently with a libxml2 regression).
I propose this change for KDE/4.14 too, and it will be forward-ported to KDocTools/KF5.
Diffs
-----
kdoctools/xslt.cpp 4d64de4
Diff: https://git.reviewboard.kde.org/r/119447/diff/
Testing
-------
Compilation of kdelibs and few modules with documentation.
Thanks,
Luigi Toscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140724/ece33877/attachment.htm>
More information about the kde-core-devel
mailing list