Review Request 119393: Offline cores segmentation fault fix

Isaac Gomez isaac at isaalx.org
Tue Jul 22 04:21:25 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119393/
-----------------------------------------------------------

Review request for kde-workspace.


Repository: ksysguard


Description
-------

[PATCH] Offline cores segmentation fault fix


Diffs
-----

  ksysguard/ksysguardd/Linux/cpuinfo.c 9427ec0 
  ksysguard/ksysguardd/Linux/stat.c 534a465 

Diff: https://git.reviewboard.kde.org/r/119393/diff/


Testing
-------

ksysguardd gets segmentation fault if a processor from the middle is offline because it takes de id as and array index; for example if we have the core 0 and 2 online but not the 1, the program will crash when trying to access array index 2 at the begining of the execution.
I changed the code to separate the array index from the id's and tested with the offline core and also with all the cores online.


Thanks,

Isaac Gomez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140722/bd6aec7a/attachment.htm>


More information about the kde-core-devel mailing list