Review Request 118994: make CTRL+SHIFT+T reopen last closed tab

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118994/#review62753
-----------------------------------------------------------

Ship it!


Thank you very much for working on this, Arjun, and thanks also for your very good suggestions, Emmanuel!

I apologize for not responding earlier. I was a bit busy at work recently and did not really find the time to check all mails and review request notifications in my inbox and see which of them could (and should) be handled quickly nevertheless (like this one).

Looks very good from my point of view. Please go ahead and push it. I have one minor suggestion for a change, but feel free to ignore it if you prefer, it's probably a matter of taste.

Thanks again for adding a useful feature, which many users will appreciate.


dolphin/src/dolphinmainwindow.cpp
<https://git.reviewboard.kde.org/r/118994/#comment43499>

    I would prefer setEnabled(count > 0) (because it makes it clear at first sight that the argument is a bool), but that might be a matter of taste.


- Frank Reininghaus


On July 6, 2014, 1:58 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118994/
> -----------------------------------------------------------
> 
> (Updated July 6, 2014, 1:58 p.m.)
> 
> 
> Review request for Dolphin and KDE Base Apps.
> 
> 
> Bugs: 336818
>     http://bugs.kde.org/show_bug.cgi?id=336818
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with the help of Go->'Recently closed tabs' menu).
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 7c3bff4 
>   dolphin/src/dolphinmainwindow.cpp d9fe645 
>   dolphin/src/dolphinrecenttabsmenu.h 34d4153 
>   dolphin/src/dolphinrecenttabsmenu.cpp a39f994 
>   dolphin/src/dolphinui.rc 52826bb 
> 
> Diff: https://git.reviewboard.kde.org/r/118994/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140720/f1896d75/attachment.htm>