Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a different directory

Thomas Lübking thomas.luebking at gmail.com
Sat Jul 19 20:42:18 BST 2014



> On Juli 19, 2014, 7:39 nachm., Thomas Lübking wrote:
> > lib/konq/konq_operations.cpp, line 474
> > <https://git.reviewboard.kde.org/r/119372/diff/1/?file=291253#file291253line474>
> >
> >     this looks while it applies to directories AND FILES.
> >     
> >     While moving a -w directory isn't possible, moving a -w file is, so this case needs to be catched?

"this looks like ..."


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/#review62714
-----------------------------------------------------------


On Juli 19, 2014, 4:44 nachm., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119372/
> -----------------------------------------------------------
> 
> (Updated Juli 19, 2014, 4:44 nachm.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Bugs: 337486
>     http://bugs.kde.org/show_bug.cgi?id=337486
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Fixes Bug 337486
> 
> 
> Diffs
> -----
> 
>   lib/konq/konq_operations.cpp 220a90a 
> 
> Diff: https://git.reviewboard.kde.org/r/119372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140719/ec9ce680/attachment.htm>


More information about the kde-core-devel mailing list