Review Request 119243: Better OSX integration: native file dialogs and unified title/toolbar

[RJVB Bertin]

> On July 12, 2014, 10:08 a.m., Marko Käning wrote:
> > kdeui/widgets/kmainwindow.cpp, line 244
> > <https://git.reviewboard.kde.org/r/119243/diff/1/?file=289738#file289738line244>
> >
> >     Actually, I don't know whether I want this integration as default...
> 
> Ian Wadham wrote:
>     I have tested this on my Mac OS X kdesrc-build setup. It works OK, BUT loses the KDE functionality of being able to right-click on a toolbar and select icon-size, text-position and text-visibility. The general effect is that you have one big rounded-looking bar, rather than two bars with a crease between them.  Also, strongly-colored icons seem to get dimmed out more by surrounding dark-grayness when the combined-bar window is selected than when there are two separate bars.
>     
>     Therefore I think we should avoid this one, even if it does look "cool".

I also noticed that text-only toolbars in bold typeface get to be rendered "double-bold". I agree, it looks nice, but shouldn't lead to loss of functionality.


- RJVB


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119243/#review62168
-----------------------------------------------------------


On July 14, 2014, 6:15 p.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119243/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 6:15 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, kdelibs, Christoph Feck, Ian Wadham, and RJVB Bertin.
> 
> 
> Bugs: 337356
>     http://bugs.kde.org/show_bug.cgi?id=337356
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This bundles both patches submitted by René J.V. Bertin in the associated issue
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kmainwindow.cpp 85beaccdb6f123d2996b8c2b5e38435265c63ff8 
>   kio/kfile/kfiledialog.h 2b11796897ff095279e7c254a383a9e8e323ea0f 
>   kio/kfile/kfiledialog.cpp 4005ba304a18b59572cc1aece3fcd122ce05fda9 
> 
> Diff: https://git.reviewboard.kde.org/r/119243/diff/
> 
> 
> Testing
> -------
> 
> See issue for more info from René.
> 
> ---
> 
> I myself haven't yet tested this. Will report back as soon as I got to it.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140716/8f9bad26/attachment.htm>