Review Request 117957: kcm_fonts: correctly restore default configuration values

[Andrea Iacovitti]

> On July 9, 2014, 8:26 a.m., Andrea Iacovitti wrote:
> > If there are no objections or other suggestions it would be good to have the bug fixed in 4.11.11 release :)
> 
> Christoph Feck wrote:
>     Thanks Andrea. Could you please check if this also affects bug 244857, bug 325868, or bug 326971 ? Their descriptions all seem to be related.

Unfortunately it seems they are different issues. In particular bug 244857 (i marked 325868 as aduplicate of this one) is about the inability to reset to system default font configuration. There is a TODO comment in fonts.cpp code that mentions this issue "TODO: With AASystem the changes already made by this module should be reverted somehow." (line 787)


- Andrea


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117957/#review61954
-----------------------------------------------------------


On July 9, 2014, 7:39 p.m., Andrea Iacovitti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117957/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 7:39 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Bugs: 324728
>     http://bugs.kde.org/show_bug.cgi?id=324728
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> When restoring default configuration:
> - Disable "Exclude range checkbox"
> - Enable/Disable "Configure..." button accordingly to antialias setting
> 
> 
> Diffs
> -----
> 
>   kcontrol/fonts/fonts.cpp cf21cb1 
> 
> Diff: https://git.reviewboard.kde.org/r/117957/diff/
> 
> 
> Testing
> -------
> 
> Tested it compiles and works as expected
> 
> 
> Thanks,
> 
> Andrea Iacovitti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140715/6525c85a/attachment.htm>