Review Request 119221: Don't rewrite mailto: URLs als mailto://

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119221/#review62400
-----------------------------------------------------------


Looks good, apart from the issue below.

https://codereview.qt-project.org/89860 shows that this should be fine in Qt5/KF5.


kdecore/io/kurl.cpp
<https://git.reviewboard.kde.org/r/119221/#comment43337>

    This comparison should be case insensitive, see (QString::compare(scheme(), QLatin1String("mailto"), Qt::CaseInsensitive) == 0 in KUrl::url().


- David Faure


On July 14, 2014, 4:47 p.m., Felix Geyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119221/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 4:47 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KUrl::prettyUrl() rewrites mailto: URLs als mailto:// if the "path" is empty.
> MUAs don't handle mailto:// URLs correctly.
> 
> mailto:test at example.com
> and
> mailto:?to=test at example.com
> are both valid and semantically equivalent.
> 
> KUrl::prettyUrl() converts the latter one to mailto://?to=test@example.com
> 
> This works fine:
> kde-open mailto:test at example.com
> 
> but this fails:
> kde-open mailto:?to=test at example.com
> 
> For example with Thunderbird it creates a mail with:
> To: //
> To: test at example.com
> 
> The mailto:// behavior was introduced with http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=c67bfaf855e2345fd08951172e5fb32b38804fa5
> 
> The proposed change special cases mailto so it always uses mailto: instead of mailto://.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kurl.cpp 8c491f7 
>   kdecore/tests/kurltest.cpp 1fd204f 
> 
> Diff: https://git.reviewboard.kde.org/r/119221/diff/
> 
> 
> Testing
> -------
> 
> Tested with kdelibs 4.13.2 and Thunderbird, Evolution and KMail.
> 
> 
> Thanks,
> 
> Felix Geyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140715/903c1e09/attachment.htm>