Review Request 119240: Preventing a crash in the KWindowInfo::Private destructor on OSX

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119240/
-----------------------------------------------------------

(Updated July 14, 2014, 11:26 p.m.)


Review request for kdelibs, David Faure, Martin Gräßlin, Ian Wadham, Thomas Lübking, and RJVB Bertin.


Changes
-------

Remove the comment, as it will finally be kept in this RR as well as the commit message.


Bugs: 337154
    http://bugs.kde.org/show_bug.cgi?id=337154


Repository: kdelibs


Description
-------

Preventing a crash in the KWindowInfo::Private destructor on OSX (thanks to René J.V. Bertin) for Qt4!

(Unclear is atm where this would have to be fixed in KF5.)

See also this: https://developer.apple.com/library/mac/documentation/CoreFoundation/Reference/CFTypeRef/Reference/reference.html#//apple_ref/c/func/CFRelease


Diffs (updated)
-----

  kdeui/windowmanagement/kwindowinfo_mac.cpp ca502a3c643af36f4a52bb6dcbc7b54fbe3f42a9 

Diff: https://git.reviewboard.kde.org/r/119240/diff/


Testing
-------

For more details see associated bug


Thanks,

Marko Käning

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140714/6ab32dd2/attachment.htm>