Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

[Vadim Zhukov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119025/
-----------------------------------------------------------

(Updated Июль 12, 2014, 5:12 п.п.)


Review request for kde-workspace, Plasma and Hui Ni.


Changes
-------

As a last resort for the patch to be reviewed, adding nihui@ to reviewers, who committed to the ibus-panel last times.


Repository: kimtoy


Description
-------

The ibus-panel can't build on OpenBSD because some required definitions obtained from pkgconfig file are not used. This happens due to the following reasons:

1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt
2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time

This patch resolves both issues and makes ibus-panel compile on OpenBSD.

(I found no suitable review group and therefore used "plasma" instead, as it was in "plasma-addons" previously; please, feel free to correct me if I'm wrong and sorry for any possible inconvenience)

((as there was no feedback for more than a week, I've added "kde-workspace" group to list of reviewers, too))


Diffs
-----

  cmake/FindIBus.cmake 8250c49 
  ibus-panel/CMakeLists.txt 3a1ee49 

Diff: https://git.reviewboard.kde.org/r/119025/diff/


Testing
-------

OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, but the code is same)


Thanks,

Vadim Zhukov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140712/d09429dd/attachment.htm>