Review Request 119221: Don't rewrite mailto: URLs als mailto://
Scott Kitterman
kde at kitterman.com
Fri Jul 11 02:32:48 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119221/#review62106
-----------------------------------------------------------
This change makes kdelibs consistent with RFC 2368 (which defined the mailto URL scheme).
- Scott Kitterman
On July 10, 2014, 8:40 p.m., Felix Geyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119221/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 8:40 p.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> KUrl::prettyUrl() rewrites mailto: URLs als mailto:// if the "path" is empty.
> MUAs don't handle mailto:// URLs correctly.
>
> mailto:test at example.com
> and
> mailto:?to=test at example.com
> are both valid and semantically equivalent.
>
> KUrl::prettyUrl() converts the latter one to mailto://?to=test@example.com
>
> This works fine:
> kde-open mailto:test at example.com
>
> but this fails:
> kde-open mailto:?to=test at example.com
>
> For example with Thunderbird it creates a mail with:
> To: //
> To: test at example.com
>
> The proposed change special cases mailto so it always uses mailto: instead of mailto://.
>
>
> Diffs
> -----
>
> kdecore/io/kurl.cpp 8c491f7
> kdecore/tests/kurltest.cpp 1fd204f
>
> Diff: https://git.reviewboard.kde.org/r/119221/diff/
>
>
> Testing
> -------
>
> Tested with kdelibs 4.13.2 and Thunderbird, Evolution and KMail.
>
>
> Thanks,
>
> Felix Geyer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140711/874c8577/attachment.htm>
More information about the kde-core-devel
mailing list