Review Request 119014: KUrlRequester: fixing handling of start directory

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119014/#review61955
-----------------------------------------------------------


Looks good, but I'd feel safer if the unittest (kio/tests/kurlrequestertest.cpp) was:
1) checked for no regressions, and
2) extended to cover the case of relative paths, and other things this patch is fixing.


kio/kfile/kurlrequester.h
<https://git.reviewboard.kde.org/r/119014/#comment43132>

    trailing space (here and everywhere reviewboard shows red - please fix)


- David Faure


On June 29, 2014, 3:04 p.m., Simon Bachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119014/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 3:04 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Bugs: 92237
>     http://bugs.kde.org/show_bug.cgi?id=92237
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The handling of the start directory in the KUrlRequester is only halfway implemented. 
> More in detail:
> - m_startDir (the private field holding the start directory) is not initialised - the default value of startDir() is an empty URL instead of the current working dir.
> - when the start dir changes, it is not always passed to the KUrlCompletion object of the lineedit. The suggestions showed when entering a relative path into the LineEdit might be wrong as a consequence.
> - when selecting a file, the start directory does not change to the directory of the selected file - the API doc says it should. 
> - when the user entered a relative path into the LineEdit, url() returns a relative path instead of an absolute one.
> 
> This patch should fix these issues. 
> 
> 
> Diffs
> -----
> 
>   kio/kfile/kurlrequester.h 2083d4c 
>   kio/kfile/kurlrequester.cpp 661b428 
> 
> Diff: https://git.reviewboard.kde.org/r/119014/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Simon Bachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140709/cebfdc85/attachment.htm>