Review Request 119088: powerdevil - don't leak job pointer in brightness control
Martin Bříza
mbriza at redhat.com
Wed Jul 2 19:03:21 BST 2014
> On July 2, 2014, 5:55 p.m., Lamarque Souza wrote:
> > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp, line 401
> > <https://git.reviewboard.kde.org/r/119088/diff/1/?file=286671#file286671line401>
> >
> > A line with 'delete job' before this return is missing here.
>
> Emmanuel Pescosta wrote:
> QScopedPointer?
> Also in other places.
yeah, sorry, forgot to regenerate the patch
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119088/#review61501
-----------------------------------------------------------
On July 2, 2014, 6:02 p.m., Martin Bříza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119088/
> -----------------------------------------------------------
>
> (Updated July 2, 2014, 6:02 p.m.)
>
>
> Review request for kde-workspace.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> Fixes a memory leak in backlight control with upower. Probably fixes https://bugs.kde.org/show_bug.cgi?id=271934 .
>
>
> Diffs
> -----
>
> powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp d38a28f
>
> Diff: https://git.reviewboard.kde.org/r/119088/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Bříza
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140702/21487083/attachment.htm>
More information about the kde-core-devel
mailing list