Review Request 115408: Right align mime icon in kpropertiesdialog

kdeuser56 kdeuser56 kdeuser56 at gmail.com
Thu Jan 30 21:23:42 GMT 2014



> On Jan. 30, 2014, 9:20 p.m., Thomas L├╝bking wrote:
> > tried to center align it?

Center what? The widget or the iconlabel? I think in case of the widget it makes no sense. 
In case of the iconlabel the icon itself would be on the exact same position as the icon of the icon button. 
I tried both, but I find right aligned prettier and more logical considering the text under it. 


- kdeuser56


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115408/#review48658
-----------------------------------------------------------


On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115408/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2014, 9:07 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The iconbutton and the iconlabel were clearly aligned using the old style, when everything was left aligned.
> In my interpretation of the KDE HIG guidelines, the iconbutton/label should also be right aligned.  
> Especially with bigger font sizes, the visual issue becomes obvious. 
> 
> Idea: see kproperties-dolphin-1.png
> Before: see before-1.png and before-2.png 
> After: see after-1.png and after-2.png
> 
> Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w
> 
> 
> Diffs
> -----
> 
>   kio/kfile/kpropertiesdialog.cpp 6611ee7 
> 
> Diff: https://git.reviewboard.kde.org/r/115408/diff/
> 
> 
> Testing
> -------
> 
> Compiled and installed. Works as expected. 
> 
> 
> File Attachments
> ----------------
> 
> idea
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png
> before1
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png
> before2
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png
> after1
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png
> after2
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png
> 
> 
> Thanks,
> 
> kdeuser56 kdeuser56
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140130/023d158c/attachment.htm>


More information about the kde-core-devel mailing list