Review Request 115311: [kwin] Don't call into GL without a context

[James Jones]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115311/
-----------------------------------------------------------

(Updated Jan. 27, 2014, 10:02 p.m.)


Review request for kde-workspace, Thomas Lübking and Marco Martin.


Changes
-------

Added formatted patch as requested.  I don't have commit access, and didn't plan on requesting.  Unfortunately, I probably won't be a frequent contributor, so it probably isn't worth the trouble.  Thanks for your help with this change Thomas.


Repository: kde-workspace


Description
-------

[kwin] Don't call into GL without a context

After losing current from the EGL or GLX
context, calls to the GL or GLES functions
have undefined behavior.  Perform all
cleanup that may touch OpenGL and check for
GL errors before losing current from the
context.


Diffs
-----

  kwin/egl_wayland_backend.cpp b229cdd84161a64d5cd93c189514067867773e7f 
  kwin/eglonxbackend.cpp dd41da55b94821802f2d1464794db39bd636088a 
  kwin/glxbackend.cpp 73f463e9df43c2cd71836ce3f48da84fb4df35ed 
  kwin/scene_opengl.cpp 961e81fbcc39940bc49179899e034ad8a9e802cd 

Diff: https://git.reviewboard.kde.org/r/115311/diff/


Testing
-------

Compiled/Installed kde-workspace on x86
kwin_gles (EGL+X11) - Tested mode switching
kwin (GLX) - Tested mode switching


File Attachments (updated)
----------------

git-format-patch version of patch
  https://git.reviewboard.kde.org/media/uploaded/files/2014/01/27/11681ec3-81a1-4a02-a165-6e442f4e21f5__0001-kwin-Don-t-call-into-GL-without-a-context.patch


Thanks,

James Jones

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140127/b32172f2/attachment.htm>