Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114737/
-----------------------------------------------------------

(Updated Jan. 26, 2014, 10:43 a.m.)


Review request for kde-workspace and David Stephen Hubner.


Changes
-------

- changed the type of the FileName parameter to const QString &
- call QProcess::waitForFinished() instead of QProcess::waitForReadyRead() to get rid of a runtime warning ("QProcess: Destroyed while process is still running.")


Repository: kde-workspace


Description
-------

This patch reimplements the ReadPipe() function by using QProcess instead of popen().
This should make it more portable.

As a positive side-effect, this also removes those "sh: lspci: command not found." messages when run in Konsole and lspci is not in the user's path.

This was suggested on the kde-core-devel mailinglist in November:
http://lists.kde.org/?l=kde-core-devel&m=138407113011843&w=2
http://lists.kde.org/?l=kde-core-devel&m=138409755820003&w=2


Diffs (updated)
-----

  kinfocenter/Modules/opengl/opengl.cpp 8901957 

Diff: https://git.reviewboard.kde.org/r/114737/diff/


Testing
-------

Ran KInfocenter with lspci in /usr/bin/ (i.e. in the user's path) and /sbin/ (not in the user's path). The OpenGL module showed the 3D accelerator info correctly in both cases.
With lspci removed completely it showed "unknown" as expected.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140126/82f9d3ea/attachment.htm>