Review Request 114956: Add support for getting a samba share's total size and free space through KIO

[Mark Gaiser]

> On Jan. 24, 2014, 8:44 a.m., David Faure wrote:
> > For KDE 4.x, a "special" command is the only way, so IMHO this can go in.
> > 
> > At the same time, it would indeed be nice to write a proper Job class for this in KIO (don't make it part of KDiskFreeSpaceInfo, that one has a sync API. This is like QFile (sync) and KIO::get (async)). This requires a new virtual method in SlaveBase, which is why it can't go into 4.x.
> 
> David Faure wrote:
>     Forgot to say it explicitely: when I say "create a job class and add a virtual method" I'm talking about KF5, i.e. kio.git branch master.
> 
> Mathias Tillman wrote:
>     I've been trying build a working implementation for KF4 (and then port it over to 5), but as of yet I have been unable to get it to work. I haven't looked much at KF5 yet, is it hugely different?

@Mathias, i have ported the SMB slave from KF4 to KF5. It's not very different.
KUrl -> QUrl changes
qDebug -> qCDebug changes

That's about all.

But be aweare with KUrl -> QUrl porting. It's best to look at the KUrl class in the kde4support branch [1] and see how function calls changed.

[1] http://quickgit.kde.org/?p=kde4support.git&a=blob&h=4ac893382c76def83f8e6e12698931df243085f9&hb=57b8159fb6bed607d7eef6ec580077484d554207&f=src%2Fkdecore%2Fkurl.h


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114956/#review48175
-----------------------------------------------------------


On Jan. 10, 2014, 6:07 p.m., Mathias Tillman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114956/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2014, 6:07 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Bugs: 245226
>     http://bugs.kde.org/show_bug.cgi?id=245226
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> Added support for getting a samba share's total size and the current free space through a special KIO command, which will be used in dolphin's statusbar to show the free space.
> 
> 
> Diffs
> -----
> 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: https://git.reviewboard.kde.org/r/114956/diff/
> 
> 
> Testing
> -------
> 
> I have written the code to implement it in dolphin, where it seems to work fine.
> 
> 
> Thanks,
> 
> Mathias Tillman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140124/64782c49/attachment.htm>