Review Request 115183: KRunner: reset history when showing (to be consistent with shells)

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115183/
-----------------------------------------------------------

Review request for kde-workspace.


Bugs: 314690
    http://bugs.kde.org/show_bug.cgi?id=314690


Repository: kde-workspace


Description
-------

The referenced bug describes a recent change in the KRunner command history which makes recalling previous commands confusing, and different to the way that history recall works in Bash and other shells.  I don't know whether this change was deliberate or accidental, but in the interests of consistency this patch ensures that the command history is reset to the beginning when showing the runner.


Diffs
-----

  krunner/interfaces/default/interface.cpp 505e0aa 

Diff: https://git.reviewboard.kde.org/r/115183/diff/


Testing
-------

Built kde-workspace with this change, verified operation of runner history.  Also verified by another bug reporter.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140121/61cc7e01/attachment.htm>