Moving Baloo and Baloo-widgets into KDE SC

David Edmundson david at
Sun Jan 19 14:56:17 GMT 2014

Code Review of baloo/file/lib


Should it override type() from Item and set it to "File" ?


The code won't unset a rating, comments or tags on multiple files.
You update Xapian ok, but you're not calling fsetxattr().

The d  pointer leaks?



Are you planning on putting all the Xapian queries in a new thread in
the future? If not having a KJob API doesn't have any benefit does it?

I would suggest you namespace your header guards
#ifndef FILE_H -> #ifndef BALOO_FILE_H
The current ones are very generic, it will be very easy to accidentally clash.



More information about the kde-core-devel mailing list