Review Request 114472: kjs: Implement ES6 Number parseInt, parseFloat

Commit Hook null at kde.org
Thu Jan 16 17:56:31 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114472/#review47530
-----------------------------------------------------------


This review has been submitted with commit a90bc6f4be7c382c1c6d7b5b4860e49d2902bb81 by Bernd Buschinski to branch KDE/4.12.

- Commit Hook


On Dec. 15, 2013, 10:07 a.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114472/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2013, 10:07 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kjs: Implement ES6 Number parseInt, parseFloat
> 
> NOTE: unlike the other new ES6 Number function these two MUST behave the same as the global parseInt/parseFloat.
> The explicit number type check is only valid for the other functions, not for parseInt/parseFloat and therefor was moved to the functions.
> 
> 
> Diffs
> -----
> 
>   kjs/function.h 17958ab 
>   kjs/function.cpp 1102208 
>   kjs/number_object.h 634c642 
>   kjs/number_object.cpp c284746 
> 
> Diff: https://git.reviewboard.kde.org/r/114472/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140116/197654e5/attachment.htm>


More information about the kde-core-devel mailing list