Review Request 114738: kjs: Implement ES6 Object.is

Bernd Buschinski b.buschinski at googlemail.com
Thu Jan 16 17:45:28 GMT 2014



> On Dec. 30, 2013, 12:54 p.m., Harri Porten wrote:
> > kjs/object_object.cpp, line 48
> > <https://git.reviewboard.kde.org/r/114738/diff/1/?file=227963#file227963line48>
> >
> >     Trailing whitespace.

thx, locally fixed. (yes I am to lazy to upload the diff here again)


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114738/#review46445
-----------------------------------------------------------


On Dec. 30, 2013, 10:53 a.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114738/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 10:53 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kjs: Implement ES6 Object.is
> 
> I bet this will be used a million times in the new es6 ecmatests, and its the first (easy way) to check the +0 vs. -0 difference.
> 
> 
> Diffs
> -----
> 
>   kjs/object_object.cpp d88912b 
> 
> Diff: https://git.reviewboard.kde.org/r/114738/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140116/e37c9fa3/attachment.htm>


More information about the kde-core-devel mailing list