Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

[Aurélien Gâteau]

> On Jan. 14, 2014, 9:05 a.m., Aurélien Gâteau wrote:
> > Makes sense to me, go for it.
> 
> Frank Reininghaus wrote:
>     Thanks!
>     
>     BTW, I was just going to forward-port the patch to Frameworks (kwidgetsaddons), but I see that KMessageWidget does not use KStandardAction any more. I think that this means that no shortcut is assigned to the "close" action in Frameworks anyway, so this patch is not needed there. If I got that wrong, please let me know.

You are right, the patch is not needed for KF5.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114686/#review47356
-----------------------------------------------------------


On Jan. 14, 2014, 9:30 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114686/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 9:30 p.m.)
> 
> 
> Review request for kdelibs and Aurélien Gâteau.
> 
> 
> Bugs: 317306
>     http://bugs.kde.org/show_bug.cgi?id=317306
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> KMessageWidget uses KStandardAction::close() to create its "close" action. This automatically sets Ctrl+W as the shortcut for that action. Unfortunately, this shortcut may conflict with application-specific shortcuts. E.g., Dolphin uses Ctrl+W for closing tabs, which means that the user will get an annoying "shortcut conflict" error message if Ctrl+W is pressed while multiple tabs are open, and the current tab has a message shown in a KMessageWidget.
> 
> I propose to solve this problem by not using a default shortcut for KMessageWidget's "close" action. I'd prefer to change this in master only to prevent causing trouble for people who might rely on the current behavior.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kmessagewidget.cpp e5143cc 
> 
> Diff: https://git.reviewboard.kde.org/r/114686/diff/
> 
> 
> Testing
> -------
> 
> I don't get a dialog showing the "Ambiguous shortcut" message any more in the described use case.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140114/41364974/attachment.htm>