Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114686/
-----------------------------------------------------------

(Updated Jan. 14, 2014, 8:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and Aurélien Gâteau.


Bugs: 317306
    http://bugs.kde.org/show_bug.cgi?id=317306


Repository: kdelibs


Description
-------

KMessageWidget uses KStandardAction::close() to create its "close" action. This automatically sets Ctrl+W as the shortcut for that action. Unfortunately, this shortcut may conflict with application-specific shortcuts. E.g., Dolphin uses Ctrl+W for closing tabs, which means that the user will get an annoying "shortcut conflict" error message if Ctrl+W is pressed while multiple tabs are open, and the current tab has a message shown in a KMessageWidget.

I propose to solve this problem by not using a default shortcut for KMessageWidget's "close" action. I'd prefer to change this in master only to prevent causing trouble for people who might rely on the current behavior.


Diffs
-----

  kdeui/widgets/kmessagewidget.cpp e5143cc 

Diff: https://git.reviewboard.kde.org/r/114686/diff/


Testing
-------

I don't get a dialog showing the "Ambiguous shortcut" message any more in the described use case.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140114/974424f8/attachment.htm>