Review Request 115001: add kf5 namespace to kglobalaccel dbus interface

[Hrvoje Senjan]

> On Jan. 13, 2014, 6:03 p.m., Martin Gräßlin wrote:
> > Wouldn't that break KDElibs4 applications talking to kglobalacceld from KF5?
> 
> Thomas Lübking wrote:
>     On Montag, 13. Januar 2014 19:24:12 CEST, Michael Jansen wrote:
>     > Yes it would. There can be only one kglobalaccel. If its from kde4 or kde4 
>     > shouldn't matter so it HAS to keep dbus compatibility.
>

This would break KF5 applications also ;-) Interface names in xml files are untouched in this review =)
@Jonathan, IMHO either leave kglobalshortcutseditor.cpp as is now, or also adjust names in interfaces (first option seems better to me).


- Hrvoje


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115001/#review47339
-----------------------------------------------------------


On Jan. 13, 2014, 3:51 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115001/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 3:51 p.m.)
> 
> 
> Review request for kde-workspace and Martin Klapetek.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> add kf5 namespace to kglobalaccel dbus interface to prevent files and runtime interfaces overlapping with kdelibs 4
> Goes with these reviews for kf5 and kde-runtime
> https://git.reviewboard.kde.org/r/114999/
> https://git.reviewboard.kde.org/r/115000/
> 
> 
> Diffs
> -----
> 
>   kcontrol/keys/CMakeLists.txt 072e614 
>   kcontrol/keys/kglobalshortcutseditor.cpp ca11fcd 
> 
> Diff: https://git.reviewboard.kde.org/r/115001/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140113/6efd42cc/attachment.htm>