Review Request 115001: add kf5 namespace to kglobalaccel dbus interface
Martin Gräßlin
mgraesslin at kde.org
Mon Jan 13 18:03:37 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115001/#review47339
-----------------------------------------------------------
Wouldn't that break KDElibs4 applications talking to kglobalacceld from KF5?
- Martin Gräßlin
On Jan. 13, 2014, 4:51 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115001/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 4:51 p.m.)
>
>
> Review request for kde-workspace and Martin Klapetek.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> add kf5 namespace to kglobalaccel dbus interface to prevent files and runtime interfaces overlapping with kdelibs 4
> Goes with these reviews for kf5 and kde-runtime
> https://git.reviewboard.kde.org/r/114999/
> https://git.reviewboard.kde.org/r/115000/
>
>
> Diffs
> -----
>
> kcontrol/keys/CMakeLists.txt 072e614
> kcontrol/keys/kglobalshortcutseditor.cpp ca11fcd
>
> Diff: https://git.reviewboard.kde.org/r/115001/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140113/c2b8e799/attachment.htm>
More information about the kde-core-devel
mailing list