Review Request 114984: Fix build on MinGW with newer Windows SDK's strsafe.h

Andrius da Costa Ribas andriusmao at gmail.com
Sun Jan 12 15:55:06 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114984/
-----------------------------------------------------------

Review request for KDE Runtime and kdewin.


Repository: kde-runtime


Description
-------

When building with MinGW new conflicts appeared when including strsafe before Qt headers (specially QString included from QBuffer). Also a new weird compiling error telling "'lstrcpy_instead_use_stringcbcopy_or_stringcchcopy' undeclared identifier" appeared, so I replaced lstrcpy with the equivalent use of StringCchCopy (http://msdn.microsoft.com/en-us/library/windows/desktop/ms647527(v=vs.85).aspx).


Diffs
-----

  kioslave/thumbnail/icoutils_win.cpp e223aa1 

Diff: https://git.reviewboard.kde.org/r/114984/diff/


Testing
-------

Tested using MinGW, thumbnails still work fine. No errors when building with MSVC either.


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140112/ded7ca5f/attachment.htm>


More information about the kde-core-devel mailing list