Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113866/#review47206
-----------------------------------------------------------


This review has been submitted with commit 9437d7700cff0331ccdcfff2875faa4a8b98cd82 by Albert Astals Cid on behalf of Stefan Brüns to branch KDE/4.12.

- Commit Hook


On Dec. 16, 2013, 6:33 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113866/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 6:33 p.m.)
> 
> 
> Review request for kdelibs and Frank Reininghaus.
> 
> 
> Bugs: 320006
>     http://bugs.kde.org/show_bug.cgi?id=320006
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Only iterate over element nodes, and filter on <folder> tag.
> 
> findFirstChild/nextSibling might return a node which is not an QDomElement. toElement will return NULL and accessing it will crash.
> 
> Possible fix for 320006
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmark.cc 8459a02 
> 
> Diff: https://git.reviewboard.kde.org/r/113866/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140111/a9cd7705/attachment.htm>