Review Request 113607: Install all user agent desktop files

Maarten De Meyer de.meyer.maarten at gmail.com
Sat Jan 11 16:08:49 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113607/#review47194
-----------------------------------------------------------


Bump?
This is a very trivial change. Should I just commit this kind of stuff in the future instead of letting it rot for weeks?

- Maarten De Meyer


On Nov. 4, 2013, 5:19 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/113607/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 5:19 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Currently each user agent file has to be listed separately in the CMakeLists.txt file. The latest commit that added new files forgot to list them so they are never installed.
> Fixed properly by GLOBING for *.desktop
> 
> 
> Diffs
> -----
> 
>   konqueror/settings/kio/uasproviders/CMakeLists.txt 6c49f42 
> 
> Diff: https://git.reviewboard.kde.org/r/113607/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> Nobody gets left behind!
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140111/ebff43fb/attachment.htm>


More information about the kde-core-devel mailing list