Review Request 110388: Change default thumbnail cache directory

[Maarten De Meyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110388/
-----------------------------------------------------------

(Updated Jan. 11, 2014, 3:15 p.m.)


Status
------

This change has been discarded.


Review request for kdelibs.


Bugs: 319528
    http://bugs.kde.org/show_bug.cgi?id=319528


Repository: kdelibs


Description
-------

The freedesktop spec[0] has changed the default location of the thumbnail cache directory.
Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of ~/.thumbnails/
GNOME has already made this change.

Some applications[1] and documentation[2] (maybe thumbnailers) will have to be changed to adapt to this new directory. If this patch is accepted I'll make the needed changes.
For frameworks we can use QStandardPaths::CacheLocation, I'll post a separate review for that.

All thumbnails will have to be regenerated. We could symlink the directory?
Is fromLocal8Bit correct or is UTF8 needed now?

[0] http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html
[1] configurepreviewdialog.cpp in Dolphin
[2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails


Diffs
-----

  kio/kio/previewjob.cpp 01b674d 

Diff: https://git.reviewboard.kde.org/r/110388/diff/


Testing
-------

Remove ~/.thumbnails/
Run dolphin with previews: thumbnails are created in .cache/thumbnails/

Repeated with XDG_CACHE_HOME=~/.cachetestdir/
Thumbnails in .cachetestdir/thumbnails/

Not tested: gwenview and digikam.


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140111/271d98d2/attachment.htm>