Review Request 114926: Append "-viewmode" to the view actions from DolphinPart
David Faure
faure at kde.org
Thu Jan 9 13:23:25 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114926/#review47102
-----------------------------------------------------------
Ship it!
Ship It!
- David Faure
On Jan. 9, 2014, 1:21 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114926/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 1:21 p.m.)
>
>
> Review request for KDE Base Apps and David Faure.
>
>
> Bugs: 322686
> http://bugs.kde.org/show_bug.cgi?id=322686
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> The attached patch fixes a bug where the actions for the views from the DolphinPart don't have "-viewmode" appended to them and hence are not correctly updated when slotInternalViewModeChanged() is invoked. This results the View->View Mode items not being updated correctly when the mode is changed through Dolphin's view mode toolbar.
>
>
> Diffs
> -----
>
> konqueror/src/konqmainwindow.cpp 8a21c1b
>
> Diff: https://git.reviewboard.kde.org/r/114926/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140109/5d0d2863/attachment.htm>
More information about the kde-core-devel
mailing list