Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)" inside

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114889/
-----------------------------------------------------------

(Updated Jan. 7, 2014, 4:24 p.m.)


Review request for kdelibs.


Changes
-------

Updated patch to follow Chusslove's proposal for runtime performance improvement.


Repository: kio


Description (updated)
-------

Seems the code behind i18n() in kf5 does not like %-placeholders without any arguments passed in the i18n call. And thus inserts the warning.
(Effect can be seen e.g. in Okteta's File Info tool).

Attached patch fixes that, by passing as argument a string with an argument placeholder again.


Diffs (updated)
-----

  src/core/global.cpp 42f453b 

Diff: https://git.reviewboard.kde.org/r/114889/diff/


Testing
-------

Results of KIO::convertSize(...) displays fine in Okteta with the patch.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140107/baf2f19d/attachment.htm>