Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

[Thomas Lübking]

> On Jan. 7, 2014, 8:51 a.m., Martin Gräßlin wrote:
> > how does that behave with the normal locker (that is no screensaver)?

"None" is not "blank" - the patch is correct.

If a cursor is specified, it is displayed regardless of what window the pointer is in. If None is specified, the normal cursor for that window is displayed when the pointer is in grab_window or one of its subwindows; otherwise, the cursor for grab_window is displayed.
--- http://tronche.com/gui/x/xlib/input/XGrabPointer.html

Since the screenlocker qml window (nor the batterysucking fancy show) is not the grab_window, both will initially get the default cursor of the grab_window (atm. the left_arrow) and not receive mouse events (so w/ or w/o the patch, the qml locker will not display an I-beam when hovering the lineedit - at least not here, one would have to poll the mouse for this and don't you dare* ;-)

W/o an explicit grab_cursor, it however should be possible (never tested, but seems the case given the patch) to alter the cursor shape from other clients at any time (because it's not important for the grabbing client)

* unless we make use of http://keithp.com/blogs/Cursor_tracking/ for PW/2


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114841/#review46960
-----------------------------------------------------------


On Jan. 5, 2014, 8:55 a.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114841/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 8:55 a.m.)
> 
> 
> Review request for kde-workspace and Martin Gräßlin.
> 
> 
> Bugs: 311571 and 316459
>     http://bugs.kde.org/show_bug.cgi?id=311571
>     http://bugs.kde.org/show_bug.cgi?id=316459
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the Screen savers from blanking the mouse cursor.
> 
> I don't know why this has been done in the first place, but I couldn't see any negative effect by setting it to None. Now the mouse cursor even changes to the IBeam again when over the password field, which I find more intuitive.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/ksldapp.cpp f0526cf 
> 
> Diff: https://git.reviewboard.kde.org/r/114841/diff/
> 
> 
> Testing
> -------
> 
> Configure a Screen saver in systemsettings and wait for it to kick in (or lock the screen manually).
> Previously (since 4.10) the mouse cursor stayed visible, now it is blanked like it was the case before 4.10.
> Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse cursor appear again as it should, regardless of whether the screen is locked or not.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140107/132eae92/attachment.htm>