Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)" inside

[Chusslove Illich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114889/#review46964
-----------------------------------------------------------


This code was originally like this (more or less), but someone complained
about performance of unit formatting. Then the code was switched away from
normal i18n calls, to use an internal low-level method of KLocale that would
fetch translation only once and cache it, later only substituting the
argument. When splitting into frameworks, this internal method was no longer
available, so the quick switch back to normal i18n left it in this semi-
correct state. The question now is whether to use correct i18n, as in your
patch, or to go back to a caching solution.

Without that low-level method, the caching solution would go by substituting
right away the literal "%1" as the argument (e.g.
i18nc("size in 10^6 bytes", "%1 MB", QString::fromLatin1("%1"));), caching
such translation, and subsequently using .arg on the cached translations
(similarly to that in klocale_kde.cpp in KDE 4).


- Chusslove Illich


On Jan. 6, 2014, 8 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114889/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 8 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Seems the code behind i18n() in kf5 does not like %-placeholders without any arguments passed in the i18n call. And thus inserts the warning.
> (Effect can be seen e.g. in Okteta's File Info tool).
> 
> Attached patch fixes that, by delaying the argument substitution as proposed in http://api.kde.org/frameworks-5.x-api/frameworks-apidocs/ki18n/html/prg_guide.html#spec_usage
> 
> 
> Diffs
> -----
> 
>   src/core/global.cpp 42f453b 
> 
> Diff: https://git.reviewboard.kde.org/r/114889/diff/
> 
> 
> Testing
> -------
> 
> Results of KIO::convertSize(...) displays fine in Okteta with the patch.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140107/60160493/attachment.htm>