Review Request 112335: In oxygen: Use the iconSize from mainToolbar

[Hugo Pereira Da Costa]

> On Jan. 7, 2014, 5:44 a.m., Àlex Fiestas wrote:
> > Hey hugo, is this in somehow now that oxygen uses KStyle again?

Hi Alex,
yes this has been removed from Oxygen::pixelMetric
and moved to kstyle::pixelMetric.
However it has the same issue: 

    case PM_ToolBarIconSize:
        return KIconLoader::global()->currentSize(KIconLoader::Toolbar);

so feel free to move the fix there and commit.

Hugo


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112335/#review46952
-----------------------------------------------------------


On Aug. 28, 2013, 5:09 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112335/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 5:09 p.m.)
> 
> 
> Review request for kde-workspace and Hugo Pereira Da Costa.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> In the qplatformplugin  we use information from MainToolbar (which makes sense) but in the styles we use information from Toolbar.
> 
> This unify both by using MainToolbar in styles (if accepted will modify kstyle as well).
> 
> 
> Diffs
> -----
> 
>   kstyles/oxygen/oxygenstyle.cpp 83aaf5c 
> 
> Diff: https://git.reviewboard.kde.org/r/112335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20140107/a9e7b6a5/attachment.htm>